feat(cli): add grep/find/findstr as alternative search strategy #8616
+193
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="extensions/cli/src/tools/searchCode.ts">
<violation number="1" location="extensions/cli/src/tools/searchCode.ts:75">
The fallback search uses `find -name` with the provided file pattern, but `-name` only matches the basename, so patterns with directories like `src/**/*.ts` stop working when falling back from ripgrep. Please switch to a path-aware match (e.g. `find … -path …`) to keep file filters consistent regardless of backend.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Collaborator
|
See failing tests and feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search tool on cn relies on ripgrep for searching inside files which is often not present in the running system. This leads to the model using alternative approaches which might skip search for files altogether. This PR adds grep/find utility for linux and findstr for windows.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
before
after
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Add a cross-platform fallback for CLI code search: use grep/find on Unix and findstr on Windows when ripgrep isn’t available. Improves reliability on systems without ripgrep and applies .gitignore excludes where supported.
Written for commit 66c1999. Summary will update automatically on new commits.